Skip to content

remove getImmutableFieldChanges references#31

Merged
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
rushmash91:cel-immutability
Feb 19, 2025
Merged

remove getImmutableFieldChanges references#31
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
rushmash91:cel-immutability

Conversation

@rushmash91
Copy link
Contributor

@rushmash91 rushmash91 commented Feb 18, 2025

fix aws-controllers-k8s/code-generator#565

Description of changes:
Remove getImmutableFieldChanges from hooks to support cel immutability

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm February 18, 2025 20:08
@rushmash91 rushmash91 mentioned this pull request Feb 18, 2025
Merged
@ack-prow
Copy link

ack-prow bot commented Feb 18, 2025 •
edited
Loading

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
efs-verify-attribution 84bf70f link false /test efs-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Contributor Author

rushmash91 commented Feb 18, 2025

/test efs-kind-e2e

@michaelhtm
Copy link
Member

michaelhtm commented Feb 19, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@ack-prow
Copy link

ack-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Feb 19, 2025
@ack-prow ack-prow bot merged commit e7182b8 into aws-controllers-k8s:main Feb 19, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees

@michaelhtm michaelhtm

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rushmash91 @michaelhtm